Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: put EthPubSubInner in Arc #3463

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 29, 2023

as pointed out here #3461

@mattsse mattsse requested a review from Rjected as a code owner June 29, 2023 11:52
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3463 (1c2d0bc) into main (26b80f4) will decrease coverage by 6.71%.
The diff coverage is 11.11%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rpc/rpc/src/eth/pubsub.rs 7.38% <11.11%> (-0.62%) ⬇️

... and 121 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.26% <11.11%> (-0.04%) ⬇️
unit-tests 57.40% <0.00%> (-6.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 18.24% <ø> (-4.77%) ⬇️
blockchain tree 81.69% <ø> (ø)
pipeline 74.74% <ø> (-13.15%) ⬇️
storage (db) 67.78% <ø> (-6.39%) ⬇️
trie 88.74% <ø> (-6.90%) ⬇️
txpool 48.44% <ø> (-2.93%) ⬇️
networking 71.98% <ø> (-6.03%) ⬇️
rpc 52.65% <11.11%> (-5.48%) ⬇️
consensus 59.63% <ø> (-3.16%) ⬇️
revm 32.68% <ø> (-2.46%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 76.63% <ø> (-12.04%) ⬇️

@onbjerg
Copy link
Member

onbjerg commented Jun 29, 2023

Does this close #3461? If so please link them

@mattsse mattsse linked an issue Jun 29, 2023 that may be closed by this pull request
@mattsse mattsse force-pushed the matt/chore-put-pubusb-inner-in-arc branch from 458cd3a to 4796d49 Compare June 29, 2023 20:31
@mattsse mattsse enabled auto-merge June 29, 2023 20:31
@mattsse mattsse disabled auto-merge June 29, 2023 21:36
@mattsse mattsse force-pushed the matt/chore-put-pubusb-inner-in-arc branch from 4796d49 to 1c2d0bc Compare June 29, 2023 21:36
@mattsse mattsse enabled auto-merge June 29, 2023 21:36
@mattsse mattsse added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit 7938389 Jun 29, 2023
@mattsse mattsse deleted the matt/chore-put-pubusb-inner-in-arc branch June 29, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ergonomics of JSON-RPC namespaces
2 participants