fix: add block rewards to trace_block
#3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
C-bug
mattsse
reviewed
Jun 30, 2023
Codecov Report
... and 13 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
onbjerg
requested review from
Rjected,
rakita,
joshieDo and
gakonst
as code owners
onbjerg
commented
Jun 30, 2023
| (self.inner.eth_api.block_by_id(block_id).await?, traces.as_mut()) | ||
| { | ||
| if let Some(header_td) = self.provider().header_td(&block.header.hash)? { | ||
| if let Some(base_block_reward) = base_block_reward( |
There was a problem hiding this comment.
if this is none we are past the merge and there are no block rewards and no ommers
mattsse
requested changes
Jun 30, 2023
| @@ -396,7 +399,7 @@ where | |||
| &self, | |||
| block_id: BlockId, | |||
| ) -> EthResult<Option<Vec<LocalizedTransactionTrace>>> { | |||
| let traces = self | |||
| let mut traces: Option<Vec<LocalizedTransactionTrace>> = self | |||
There was a problem hiding this comment.
perf: can use futures::try_join with the cache call
There was a problem hiding this comment.
let's do in follow-up as i'd like to unblock this asap
gakonst
force-pushed
the
onbjerg/trace-block-rewards
branch
from
5ad6a3b
to
3ccc5af
Compare
gakonst
approved these changes
Jul 2, 2023
mattsse
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3443