feat: add another distance check #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
rakita,
rkrasiuk,
Rjected,
joshieDo and
gakonst
as code owners
mattsse
added
C-perf
Codecov Report
... and 8 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gakonst
approved these changes
Jul 2, 2023
Comment on lines
+112
to
+119
| fn buffered_block_by_hash(&self, block_hash: BlockHash) -> Option<SealedBlock> { | ||
| self.tree.read().get_buffered_block(&block_hash).map(|b| b.block.clone()) | ||
| } | ||
|
|
||
| fn buffered_header_by_hash(&self, block_hash: BlockHash) -> Option<SealedHeader> { | ||
| self.tree.read().get_buffered_block(&block_hash).map(|b| b.header.clone()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Nit I'd make this return reference instead of cloning
There was a problem hiding this comment.
not possible unfortunately because can't borrow past read lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while we're downloading via tree, we're still receiving new payloads and FCU, so the sync target and the finalized block and hence the distance from local to head constantly moves, and can eventually exceed the targeted 1 epoch.
this adds another check to also lookup if we have the latest finalized block buffered so we can check the distance here again.
This prevents the scenario where we receive a future finalized block the
NewPayloadand therefore never have to download the finalized block if the FCU is updated.