feat(stages, tree): update sync metrics from blockchain tree #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
changed the title
Codecov Report
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shekhirin
requested review from
rakita,
rkrasiuk,
onbjerg and
gakonst
as code owners
gakonst
approved these changes
Jul 2, 2023
Comment on lines
+52
to
+57
| MetricEvent::SyncHeight { height } => { | ||
| for stage_id in StageId::ALL { | ||
| let stage_metrics = self.sync_metrics.get_stage_metrics(stage_id); | ||
| stage_metrics.checkpoint.set(height as f64); | ||
| } | ||
| } |
There was a problem hiding this comment.
i see, nice - i guess we dont need to do anyhting with the entities processed / entities total?
gakonst
force-pushed
the
alexey/live-sync-metrics
branch
from
8cec11e
to
3487b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2604
Currently,
reth_sync_checkpointmetric is not updated after the pipeline sync is done.This PR fixes it by sending new block heights from blockchain tree to
reth_stages::MetricsListener, which iterates over all known stages usingStageId::ALLand updates thereth_sync_checkpointgauge value.