-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(stages): use MetricsListener
for Execution stage gas metric
#3511
Conversation
7b792f7
to
98c7001
Compare
Codecov Report
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MetricsListener
for Execution stage gas metric
gm @shekhirin plans here / next steps? |
tested, RFR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - clean. I really like this pattern.
This PR finishes migrating all existing sync-related metrics to using
MetricsListener
which was introduced in #3483.