Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NoopTransactionPool impl #3536

Merged
merged 1 commit into from
Jul 3, 2023
Merged

feat: add NoopTransactionPool impl #3536

merged 1 commit into from
Jul 3, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 2, 2023

Adds a TransactionPool impl that does nothing besides satisfying the trait

This is useful for wiring components together that don't require an actual pool but still need to be generic over it.

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Jul 2, 2023
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #3536 (1aa6360) into main (4f32f56) will decrease coverage by 0.05%.
The diff coverage is 10.93%.

❗ Current head 1aa6360 differs from pull request most recent head bcd8446. Consider uploading reports for the commit bcd8446 to get more accurate results

Impacted file tree graph

Impacted Files Coverage Δ
crates/transaction-pool/src/lib.rs 36.00% <ø> (ø)
crates/transaction-pool/src/test_utils/mod.rs 100.00% <ø> (+5.55%) ⬆️
crates/transaction-pool/src/traits.rs 5.12% <0.00%> (-0.14%) ⬇️
crates/transaction-pool/src/noop.rs 11.38% <11.38%> (ø)

... and 17 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.22% <10.93%> (-0.02%) ⬇️
unit-tests 63.97% <10.93%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.02% <ø> (+0.01%) ⬆️
blockchain tree 81.25% <ø> (ø)
pipeline 86.98% <ø> (ø)
storage (db) 73.89% <ø> (+0.06%) ⬆️
trie 95.64% <ø> (ø)
txpool 49.46% <10.93%> (-1.69%) ⬇️
networking 77.87% <ø> (+0.01%) ⬆️
rpc 58.19% <ø> (+0.31%) ⬆️
consensus 62.58% <ø> (ø)
revm 34.99% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.46% <ø> (-0.04%) ⬇️

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought we had this already 😄

@mattsse mattsse added this pull request to the merge queue Jul 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2023
@gakonst
Copy link
Member

gakonst commented Jul 3, 2023

Will replace the testing_pool() in my example w/ this

@gakonst gakonst merged commit d80c8a7 into main Jul 3, 2023
@gakonst gakonst deleted the matt/add-noop-pool-impl branch July 3, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants