-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codec): fix last field compilation check #3543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you 🙏
also love the comment explaining the behaviour
Codecov Report
... and 341 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging - clippy unrelated
@@ -116,17 +116,26 @@ impl<'a> StructHandler<'a> { | |||
format_ident!("specialized_from_compact") | |||
}; | |||
|
|||
// ! Be careful before changing the following assert ! Especially if the type does not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it - seems fine to have footgun at codec-related logic, is low level enough and i like that we're highlighting it
Fixes a previously modified last field check on
compact
codec and adds additional context tomain_codec
This was probably changed to allow
CheckpointBlockRange
to be compiled. The necessary changes were introduced, and it doesn't affect the actual encoding of the value (not a db breaking change).I added a bit more context on the relevant assertion: