Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): fix parity tracing config #3549

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 3, 2023

fixes a config bug that would result in the bug reported in #3535

we incorrectly configured the config, because storage diff recording requires step recording, and step recording was disabled if no vmtrace was included

@mattsse mattsse requested a review from Rjected as a code owner July 3, 2023 12:46
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Jul 3, 2023
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse enabled auto-merge July 3, 2023 12:47
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #3549 (8d71c49) into main (4f32f56) will decrease coverage by 0.10%.
The diff coverage is 38.53%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/revm/revm-inspectors/src/tracing/config.rs 26.47% <0.00%> (-2.11%) ⬇️
crates/rpc/rpc/src/eth/api/fees.rs 48.41% <0.00%> (ø)
crates/rpc/rpc/src/eth/pubsub.rs 7.38% <0.00%> (ø)
crates/storage/libmdbx-rs/src/cursor.rs 90.45% <ø> (ø)
crates/transaction-pool/src/lib.rs 36.00% <ø> (ø)
crates/transaction-pool/src/test_utils/mod.rs 100.00% <ø> (+5.55%) ⬆️
crates/transaction-pool/src/traits.rs 5.12% <0.00%> (-0.14%) ⬇️
crates/transaction-pool/src/noop.rs 11.38% <11.38%> (ø)
crates/blockchain-tree/src/blockchain_tree.rs 81.84% <50.00%> (ø)
...rates/storage/codecs/derive/src/compact/structs.rs 81.81% <50.00%> (+0.23%) ⬆️
... and 14 more

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.24% <20.48%> (+<0.01%) ⬆️
unit-tests 63.93% <31.70%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.01% <ø> (ø)
blockchain tree 81.25% <75.00%> (ø)
pipeline 86.98% <100.00%> (ø)
storage (db) 73.62% <95.23%> (-0.21%) ⬇️
trie 95.64% <100.00%> (ø)
txpool 49.46% <10.93%> (-1.69%) ⬇️
networking 77.99% <100.00%> (+0.13%) ⬆️
rpc 57.98% <87.80%> (+0.10%) ⬆️
consensus 62.58% <ø> (ø)
revm 34.95% <28.57%> (-0.05%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 88.48% <ø> (-0.02%) ⬇️

@mattsse mattsse added the M-changelog This change should be included in the changelog label Jul 3, 2023
@mattsse mattsse added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit d848668 Jul 3, 2023
@mattsse mattsse deleted the matt/fix-state-diff-recording branch July 3, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants