Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(book): adding QLC and TLC NVMEs comparison #3562

Merged
merged 1 commit into from
Jul 3, 2023
Merged

feat(book): adding QLC and TLC NVMEs comparison #3562

merged 1 commit into from
Jul 3, 2023

Conversation

tcoratger
Copy link
Contributor

Should solve #3555.

@tcoratger tcoratger requested a review from gakonst as a code owner July 3, 2023 16:49
@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Merging #3562 (904c2d6) into main (8025b05) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

see 4 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.21% <ø> (+<0.01%) ⬆️
unit-tests 63.90% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.01% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.98% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 95.64% <ø> (ø)
txpool 49.46% <ø> (-0.63%) ⬇️
networking 77.89% <ø> (+<0.01%) ⬆️
rpc 58.02% <ø> (+0.02%) ⬆️
consensus 62.58% <ø> (ø)
revm 34.95% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.47% <ø> (ø)

gakonst
gakonst approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@gakonst gakonst added this pull request to the merge queue Jul 3, 2023
Merged via the queue into paradigmxyz:main with commit 24f9147 Jul 3, 2023
@tcoratger tcoratger deleted the hardware-book branch July 3, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @gakonst