perf: better engine downloads #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-perf
mattsse
force-pushed
the
matt/download-improvements
branch
from
37a0ae2
to
f1a226b
Compare
Codecov Report
... and 8 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
with #3588 we can keep the threshold and finalized hash |
|
cool, I'll just revert these then but keep the other changes |
rkrasiuk
reviewed
Jul 5, 2023
Comment on lines
1144
to
1146
| Ok(Some(_)) => { | ||
| // we're fully synced to the safe block | ||
| } |
There was a problem hiding this comment.
is this even reachable? under which conditions? should we still attempt to download the missing parent in this case?
There was a problem hiding this comment.
yes we should still attempt to download, because if we set the threshold to 32 but only check the finalized tag here, then this branch is common.
we need to continue downloading, otherwise it would stall
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracts a fix from #3416 where downloading would stall because we're already synced to the state.finalized hash.
this also changes the target to the safe hash and decreases the pipeline threshold to 8 blocks