Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use DatabaseRef impl when fetching overriden account #3589

Merged
merged 2 commits into from
Jul 5, 2023
Merged

fix: use DatabaseRef impl when fetching overriden account #3589

merged 2 commits into from
Jul 5, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 4, 2023

Closes #3583

account needs to be fetched via databaseref trait

@mattsse mattsse requested a review from Rjected as a code owner July 4, 2023 18:49
@mattsse mattsse mentioned this pull request Jul 4, 2023
Closed
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #3589 (5cc0bfb) into main (c236521) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rpc/rpc/src/eth/revm_utils.rs 36.98% <0.00%> (ø)

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.12% <0.00%> (-0.01%) ⬇️
unit-tests 63.96% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.41% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.91% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 95.64% <ø> (ø)
txpool 49.20% <ø> (-0.31%) ⬇️
networking 77.92% <ø> (+0.01%) ⬆️
rpc 58.02% <0.00%> (+0.02%) ⬆️
consensus 62.58% <ø> (ø)
revm 34.95% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.29% <ø> (+0.02%) ⬆️

@mattsse @rkrasiuk
Update crates/rpc/rpc/src/eth/revm_utils.rs
5cc0bfb 
Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
@mattsse mattsse enabled auto-merge July 5, 2023 09:51
@mattsse mattsse added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit ab2fc7e Jul 5, 2023
@mattsse mattsse deleted the matt/fix-state-overrides branch July 5, 2023 11:12
@gakonst
Copy link
Member

gakonst commented Jul 5, 2023

Oh man - this seems like a big footgun? How can we avoid this in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eth_Call with stateOverride returns empty data
3 participants
@mattsse @gakonst @rkrasiuk