chore(prometheus): add localhost:9001 scrape target
#3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
the
A-observability
onbjerg
approved these changes
Jul 5, 2023
Codecov Report
see 43 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
gakonst
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default Prometheus config doesn't work if Reth is running standalone, without Docker, as we describe in the book: https://paradigmxyz.github.io/reth/run/observability.html. Node exposes port 9001 on localhost, and the prometheus.yml contains only
reth:9001target for Docker.I added another target for
localhost:9001, so Prometheus will always have one target that's DOWN, but also will work without adjusting the config.