chore(txpool): enriched pool transaction event #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 179 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
approved these changes
Jul 7, 2023
Comment on lines
90
to
91
| event: TransactionEvent, | ||
| pool_event: PoolTransactionEvent<T>, |
There was a problem hiding this comment.
this could be a bit confusing at first, so I think we should add a few docs how these differ to PoolTransactionEvent and TransactionEvent
still not quite happy with the name, perhaps we rename PoolTransactionEvent to FullTransactionEvent ?
| pub fn event(&self) -> &TransactionEvent { | ||
| &self.1 | ||
| } | ||
| pub enum PoolTransactionEvent<T: PoolTransaction> { |
There was a problem hiding this comment.
This is way better than before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transform
PoolTransactionEventto enable emitted enriched data about the transaction that the event happened to.