feat: run pipeline if latest finalized is far from pipeline progress #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Codecov Report
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Rjected
force-pushed
the
dan/run-pipeline-again-if-possible
branch
from
553c7a6
to
5700912
Compare
mattsse
approved these changes
Jul 10, 2023
merklefruit
pushed a commit
to anton-rs/op-reth
that referenced
this pull request
Jul 18, 2023
merklefruit
pushed a commit
to merklefruit/op-reth-old
that referenced
this pull request
Jul 26, 2023
merklefruit
pushed a commit
to anton-rs/op-reth
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the pipeline finishes, it currently runs the
update_tree_on_finished_pipelinemethod immediately afterwards, causing a potentially large execution of buffered blocks.Now, this checks the buffer to see if the latest finalized block exists in the buffer, and checks its distance compared to the current pipeline progress. If the distance is more than the pipeline threshold, this will run the pipeline and prevent the
update_tree_on_finished_pipelinecall.