Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: handle engine API range request in a new task #3685

Merged
merged 3 commits into from
Jul 11, 2023
Merged

perf: handle engine API range request in a new task #3685

merged 3 commits into from
Jul 11, 2023

Conversation

jaylmiller
Copy link
Contributor

@jaylmiller jaylmiller commented Jul 9, 2023 •
edited by onbjerg
Loading

Hello there, first time contributing. LMK what you think!

Closes #3674

@onbjerg onbjerg changed the title Handle engine API range request in a new task #3674 feat: handle engine API range request in a new task Jul 9, 2023
@onbjerg onbjerg changed the title feat: handle engine API range request in a new task perf: handle engine API range request in a new task Jul 9, 2023
@onbjerg onbjerg added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Jul 9, 2023
mattsse
mattsse requested changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thats for taking this on, the function changes look good.

I'd like to move all fields into an Arc wrapper,

we could also do this in a follow PR, but then the Provider should still not be in an Arc here and instead restricted to be Clone

crates/rpc/rpc-engine-api/src/engine_api.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #3685 (52305bc) into main (f201176) will increase coverage by 0.09%.
The diff coverage is 91.07%.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/node/mod.rs 10.18% <0.00%> (-0.04%) ⬇️
crates/rpc/rpc-engine-api/src/engine_api.rs 89.88% <92.72%> (-0.10%) ⬇️

... and 32 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.87% <53.57%> (-0.03%) ⬇️
unit-tests 64.21% <82.14%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.31% <0.00%> (-0.04%) ⬇️
blockchain tree 81.58% <ø> (+0.32%) ⬆️
pipeline 87.11% <ø> (+0.43%) ⬆️
storage (db) 73.57% <ø> (+0.08%) ⬆️
trie 94.66% <ø> (ø)
txpool 49.59% <ø> (+0.24%) ⬆️
networking 77.84% <ø> (+<0.01%) ⬆️
rpc 58.30% <92.72%> (+0.20%) ⬆️
consensus 63.40% <ø> (+0.04%) ⬆️
revm 34.86% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.25% <ø> (-0.02%) ⬇️

@jaylmiller jaylmiller requested a review from mattsse July 10, 2023 23:22
mattsse
mattsse approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

tysm for this

@mattsse mattsse enabled auto-merge July 11, 2023 13:42
@mattsse mattsse added this pull request to the merge queue Jul 11, 2023
Merged via the queue into paradigmxyz:main with commit 1763b5e Jul 11, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
@jaylmiller @mattsse @merklefruit
perf: handle engine API range request in a new task (paradigmxyz#3685)
d9fcf9b 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
@jaylmiller @mattsse @merklefruit
perf: handle engine API range request in a new task (paradigmxyz#3685)
485cda5 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
@jaylmiller @mattsse @merklefruit
perf: handle engine API range request in a new task (paradigmxyz#3685)
c1bf47c 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle engine API range request in a new task
3 participants
@jaylmiller @mattsse @onbjerg