Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add performed pool state updates metric #3714

Merged
merged 1 commit into from
Jul 11, 2023
Merged

feat: add performed pool state updates metric #3714

merged 1 commit into from
Jul 11, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 11, 2023 •
edited
Loading

new metric helps monitor how often the has been updated on new canonical state

would need some help adding this to dashboard -.- @onbjerg

@mattsse mattsse added A-tx-pool Related to the transaction mempool A-observability Related to tracing, metrics, logs and other observability tools labels Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #3714 (ff0d172) into main (467f6f9) will decrease coverage by 17.44%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/transaction-pool/src/metrics.rs 100.00% <ø> (ø)
crates/transaction-pool/src/pool/txpool.rs 45.29% <0.00%> (-15.29%) ⬇️

... and 209 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.86% <0.00%> (-0.02%) ⬇️
unit-tests 46.29% <0.00%> (-17.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 20.15% <ø> (-6.21%) ⬇️
blockchain tree 37.32% <ø> (-44.26%) ⬇️
pipeline 63.38% <ø> (-23.38%) ⬇️
storage (db) 50.89% <ø> (-22.63%) ⬇️
trie 62.98% <ø> (-31.68%) ⬇️
txpool 40.52% <0.00%> (-9.08%) ⬇️
networking 62.29% <ø> (-15.55%) ⬇️
rpc 44.32% <ø> (-13.91%) ⬇️
consensus 51.78% <ø> (-11.62%) ⬇️
revm 26.94% <ø> (-7.92%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 65.95% <ø> (-22.33%) ⬇️

rkrasiuk
rkrasiuk approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Jul 11, 2023
@mattsse mattsse mentioned this pull request Jul 11, 2023
Closed
Merged via the queue into main with commit 2effa94 Jul 11, 2023
@mattsse mattsse deleted the matt/add-performed-state-updates-metric branch July 11, 2023 14:41
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
@mattsse @merklefruit
feat: add performed pool state updates metric (paradigmxyz#3714)
215669a
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
@mattsse @merklefruit
feat: add performed pool state updates metric (paradigmxyz#3714)
95cfc2b
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
@mattsse @merklefruit
feat: add performed pool state updates metric (paradigmxyz#3714)
e722839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-tx-pool Related to the transaction mempool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk