Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register precompiles correctly #3720

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 11, 2023

the precompile js functions needs to be initialized before any call

initialize_interp however is called after the call hook when the interpreter is about to start

this registers the precompiles in call/crate instead

@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #3720 (002b1b8) into main (1763b5e) will decrease coverage by 10.54%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/revm/revm-inspectors/src/tracing/js/mod.rs 0.00% <0.00%> (ø)

... and 185 files with indirect coverage changes

Flag Coverage Δ
integration-tests 12.76% <0.00%> (-3.10%) ⬇️
unit-tests 54.89% <0.00%> (-9.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 19.51% <ø> (-6.80%) ⬇️
blockchain tree 74.48% <ø> (-7.10%) ⬇️
pipeline 76.31% <ø> (-10.81%) ⬇️
storage (db) 66.43% <ø> (-7.14%) ⬇️
trie 83.13% <ø> (-11.53%) ⬇️
txpool 41.83% <ø> (-7.56%) ⬇️
networking 66.02% <ø> (-11.78%) ⬇️
rpc 43.13% <ø> (-15.16%) ⬇️
consensus 55.40% <ø> (-8.01%) ⬇️
revm 26.73% <0.00%> (-8.14%) ⬇️
payload builder 4.36% <ø> (-2.48%) ⬇️
primitives 75.87% <ø> (-12.38%) ⬇️

@mattsse mattsse requested a review from Rjected July 11, 2023 21:52
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, what's the error case in the previous behavior?

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 12, 2023

I misunderstood when initialize_interpreter is called, I assumed it's called once, but it's called after the call function when, well, the interpreter for that call is initialized.

@mattsse mattsse added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit a7eae8c Jul 12, 2023
@mattsse mattsse deleted the matt/register-precompiles-js-correctly branch July 12, 2023 10:46
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants