Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(book): correct the grafana dashboards json path #3724

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Chore(book): correct the grafana dashboards json path #3724

merged 1 commit into from
Jul 11, 2023

Conversation

hsyodyssey
Copy link
Contributor

fix a miss typo

@hsyodyssey hsyodyssey requested a review from gakonst as a code owner July 11, 2023 16:15
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #3724 (15a0052) into main (fbdea30) will decrease coverage by 8.24%.
The diff coverage is n/a.

Impacted file tree graph

see 139 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.86% <ø> (-0.01%) ⬇️
unit-tests 54.64% <ø> (-9.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 24.93% <ø> (-1.38%) ⬇️
blockchain tree 78.54% <ø> (-3.04%) ⬇️
pipeline 79.09% <ø> (-8.03%) ⬇️
storage (db) 67.08% <ø> (-6.55%) ⬇️
trie 80.50% <ø> (-14.16%) ⬇️
txpool 41.34% <ø> (-8.05%) ⬇️
networking 66.91% <ø> (-10.91%) ⬇️
rpc 51.87% <ø> (-6.53%) ⬇️
consensus 50.71% <ø> (-12.69%) ⬇️
revm 28.95% <ø> (-5.92%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 77.69% <ø> (-10.57%) ⬇️

gakonst
gakonst approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!!

@gakonst gakonst enabled auto-merge July 11, 2023 16:40
@gakonst gakonst added this pull request to the merge queue Jul 11, 2023
Merged via the queue into paradigmxyz:main with commit 718d811 Jul 11, 2023
merklefruit pushed a commit to op-rs/op-reth that referenced this pull request Jul 18, 2023
@hsyodyssey @merklefruit
Chore(book): correct the grafana dashboards json path (paradigmxyz#3724)
bf9bb4b
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
@hsyodyssey @merklefruit
Chore(book): correct the grafana dashboards json path (paradigmxyz#3724)
a9b7e5b
merklefruit pushed a commit to op-rs/op-reth that referenced this pull request Jul 27, 2023
@hsyodyssey @merklefruit
Chore(book): correct the grafana dashboards json path (paradigmxyz#3724)
ba5ea63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsyodyssey @gakonst