Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo in RlpDecodableWrapper derive #3763

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jul 13, 2023

🤖 Generated by Copilot at c8456c3

Fixed a naming inconsistency in rlp-derive crate that caused confusion when deriving RLP decodable wrapper types. Renamed RlpEncodableWrapper function and attribute to RlpDecodableWrapper in de.rs.

@Rjected Rjected requested a review from gakonst as a code owner July 13, 2023 18:09
@mattsse mattsse enabled auto-merge July 13, 2023 18:22
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #3763 (c8456c3) into main (7edab97) will decrease coverage by 10.53%.
The diff coverage is 50.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rlp/rlp-derive/src/de.rs 94.17% <50.00%> (ø)

... and 177 files with indirect coverage changes

Flag Coverage Δ
integration-tests 13.09% <50.00%> (-2.69%) ⬇️
unit-tests 55.02% <50.00%> (-9.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 19.37% <ø> (-6.79%) ⬇️
blockchain tree 75.83% <ø> (-7.20%) ⬇️
pipeline 76.34% <ø> (-10.80%) ⬇️
storage (db) 67.10% <ø> (-7.10%) ⬇️
trie 83.12% <ø> (-11.54%) ⬇️
txpool 41.81% <ø> (-6.96%) ⬇️
networking 62.30% <ø> (-15.45%) ⬇️
rpc 49.24% <ø> (-9.24%) ⬇️
consensus 57.04% <ø> (-7.92%) ⬇️
revm 26.72% <ø> (-7.08%) ⬇️
payload builder 6.61% <ø> (ø)
primitives 74.82% <50.00%> (-13.54%) ⬇️

@mattsse mattsse added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit ac12cc4 Jul 13, 2023
@mattsse mattsse deleted the dan/fix-rlp-derive-typo branch July 13, 2023 19:26
merklefruit pushed a commit to op-rs/op-reth that referenced this pull request Jul 18, 2023
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
merklefruit pushed a commit to op-rs/op-reth that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants