Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc): make trace filter req field hex or decimal #3772

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix(rpc): make trace filter req field hex or decimal #3772

merged 1 commit into from
Jul 14, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 14, 2023

@mattsse mattsse requested review from Rjected and gakonst as code owners July 14, 2023 07:42
@mattsse mattsse requested a review from rkrasiuk July 14, 2023 07:42
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Jul 14, 2023
rkrasiuk
rkrasiuk approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that after isn't hex as well

@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Merging #3772 (6e0afb8) into main (307fc10) will decrease coverage by 8.28%.
The diff coverage is 93.75%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/primitives/src/serde_helper/num.rs 35.57% <88.88%> (-48.64%) ⬇️
crates/rpc/rpc-types/src/eth/trace/filter.rs 100.00% <100.00%> (ø)

... and 251 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.78% <43.75%> (+0.01%) ⬆️
unit-tests 46.73% <62.50%> (-8.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 19.97% <ø> (+0.60%) ⬆️
blockchain tree 41.72% <ø> (-34.11%) ⬇️
pipeline 64.07% <ø> (-12.28%) ⬇️
storage (db) 52.09% <ø> (-15.99%) ⬇️
trie 62.92% <ø> (-20.20%) ⬇️
txpool 40.95% <ø> (-0.86%) ⬇️
networking 62.24% <ø> (-4.41%) ⬇️
rpc 44.42% <100.00%> (-7.36%) ⬇️
consensus 54.05% <ø> (-3.00%) ⬇️
revm 26.35% <ø> (-0.37%) ⬇️
payload builder 6.61% <ø> (ø)
primitives 66.08% <88.88%> (-10.17%) ⬇️

@mattsse mattsse enabled auto-merge July 14, 2023 08:08
@mattsse mattsse added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit ad4c590 Jul 14, 2023
@mattsse mattsse deleted the matt/make-trace-filter-fields-hex-or-decimal branch July 14, 2023 08:46
merklefruit pushed a commit to op-rs/op-reth that referenced this pull request Jul 18, 2023
@mattsse @merklefruit
fix(rpc): make trace filter req field hex or decimal (paradigmxyz#3772)
afe2e21
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
@mattsse @merklefruit
fix(rpc): make trace filter req field hex or decimal (paradigmxyz#3772)
89074bc
merklefruit pushed a commit to op-rs/op-reth that referenced this pull request Jul 27, 2023
@mattsse @merklefruit
fix(rpc): make trace filter req field hex or decimal (paradigmxyz#3772)
8a1385a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk