Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding row for total db size in db stats command #3777

Merged
merged 2 commits into from
Jul 14, 2023
Merged

adding row for total db size in db stats command #3777

merged 2 commits into from
Jul 14, 2023

Conversation

i-m-aditya
Copy link
Contributor

@i-m-aditya i-m-aditya commented Jul 14, 2023 •
edited
Loading

Fixes #3747
Screenshot 2023-07-14 at 2 07 10 PM

@i-m-aditya i-m-aditya requested a review from onbjerg as a code owner July 14, 2023 08:36
@mattsse mattsse added C-enhancement New feature or request A-cli Related to the reth CLI labels Jul 14, 2023
mattsse
mattsse approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

pending clippy

@mattsse mattsse enabled auto-merge July 14, 2023 12:14
@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Merging #3777 (7441bb4) into main (f6646aa) will decrease coverage by 9.97%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/db/mod.rs 1.94% <0.00%> (-7.59%) ⬇️

... and 205 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.78% <0.00%> (-0.03%) ⬇️
unit-tests 54.18% <0.00%> (-10.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 24.64% <0.00%> (-1.65%) ⬇️
blockchain tree 41.72% <ø> (-41.31%) ⬇️
pipeline 79.24% <ø> (-7.88%) ⬇️
storage (db) 59.16% <ø> (-15.05%) ⬇️
trie 71.59% <ø> (-23.07%) ⬇️
txpool 44.07% <ø> (-5.31%) ⬇️
networking 68.55% <ø> (-9.34%) ⬇️
rpc 51.51% <ø> (-6.98%) ⬇️
consensus 56.80% <ø> (-8.08%) ⬇️
revm 28.68% <ø> (-5.17%) ⬇️
payload builder 6.61% <ø> (-0.23%) ⬇️
primitives 78.30% <ø> (-10.05%) ⬇️

@mattsse mattsse added this pull request to the merge queue Jul 14, 2023
Merged via the queue into paradigmxyz:main with commit 715d41d Jul 14, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
@i-m-aditya @mattsse @merklefruit
adding row for total db size in db stats command (paradigmxyz#3777)
9ded37c 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
@i-m-aditya @mattsse @merklefruit
adding row for total db size in db stats command (paradigmxyz#3777)
70fca62 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
@i-m-aditya @mattsse @merklefruit
adding row for total db size in db stats command (paradigmxyz#3777)
a457cb8 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add row for total db size to db stats subcommand
2 participants
@i-m-aditya @mattsse