-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove peers after several unsuccessful attempts #3780
feat: remove peers after several unsuccessful attempts #3780
Conversation
Codecov Report
... and 189 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems reasonable for removing offline or otherwise misbehaving peers from the peerset, lgtm
supersedes #3076
we're tracking what kind of error caused a failed dial/disconnect. if the error is severe, for example connection refused we backoff in and increase a counter.
previously peers, even offline peers weren't cleared from the peerset, but backed off with increasing duration.
this adds a new config threshold after which peers are removed from the set, for example if a peer is not reachable after the 5th attempt, it is removed from the set