Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(downloader): simplify bodies task polling #3788

Merged
merged 3 commits into from
Jul 15, 2023
Merged

chore(downloader): simplify bodies task polling #3788

merged 3 commits into from
Jul 15, 2023

Conversation

rkrasiuk
Copy link
Member

Description

Simplify bodies task downloader polling logic.

@rkrasiuk rkrasiuk requested review from Rjected and mattsse July 15, 2023 07:57
@rkrasiuk rkrasiuk requested a review from onbjerg as a code owner July 15, 2023 07:57
@codecov
Copy link

codecov bot commented Jul 15, 2023 •
edited
Loading

Codecov Report

Merging #3788 (b0c1dea) into main (715d41d) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/net/downloaders/src/bodies/task.rs 94.68% <90.00%> (+2.12%) ⬆️

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.76% <0.00%> (-0.02%) ⬇️
unit-tests 64.25% <90.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.05% <ø> (ø)
blockchain tree 83.02% <ø> (ø)
pipeline 87.13% <ø> (ø)
storage (db) 74.19% <ø> (-0.03%) ⬇️
trie 94.65% <ø> (ø)
txpool 48.76% <ø> (-0.61%) ⬇️
networking 77.67% <90.00%> (-0.05%) ⬇️
rpc 58.56% <ø> (-0.02%) ⬇️
consensus 64.96% <ø> (ø)
revm 33.76% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 88.32% <ø> (+0.02%) ⬆️

@rkrasiuk rkrasiuk requested a review from mattsse July 15, 2023 08:30
@rkrasiuk rkrasiuk requested a review from mattsse July 15, 2023 08:41
mattsse
mattsse approved these changes Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk rkrasiuk enabled auto-merge July 15, 2023 08:45
@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-downloaders Related to headers/bodies downloaders labels Jul 15, 2023
@rkrasiuk rkrasiuk added this pull request to the merge queue Jul 15, 2023
Merged via the queue into main with commit 2748bed Jul 15, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/simplify-bodies-task branch July 15, 2023 09:34
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
@rkrasiuk @merklefruit
chore(downloader): simplify bodies task polling (paradigmxyz#3788)
4d401cc
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
@rkrasiuk @merklefruit
chore(downloader): simplify bodies task polling (paradigmxyz#3788)
001c357
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
@rkrasiuk @merklefruit
chore(downloader): simplify bodies task polling (paradigmxyz#3788)
25bb87d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-downloaders Related to headers/bodies downloaders C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse