Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dial metric to dashboard #3802

Conversation

i-m-aditya
Copy link
Contributor

Fixes #3745
Screenshot 2023-07-16 at 10 27 16 AM

@i-m-aditya i-m-aditya requested a review from gakonst as a code owner July 16, 2023 04:57
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #3802 (906fb43) into main (9a00f04) will increase coverage by 0.14%.
The diff coverage is 51.25%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/stage/drop.rs 2.00% <0.00%> (-0.13%) ⬇️
crates/primitives/src/transaction/access_list.rs 53.84% <0.00%> (-23.94%) ⬇️
crates/primitives/src/withdrawal.rs 82.35% <0.00%> (-17.65%) ⬇️
crates/stages/src/metrics/listener.rs 0.00% <0.00%> (ø)
crates/transaction-pool/src/lib.rs 32.31% <0.00%> (-1.23%) ⬇️
crates/transaction-pool/src/noop.rs 11.02% <0.00%> (-0.51%) ⬇️
crates/transaction-pool/src/ordering.rs 0.00% <0.00%> (ø)
crates/transaction-pool/src/pool/best.rs 75.00% <0.00%> (-14.56%) ⬇️
crates/transaction-pool/src/pool/mod.rs 40.88% <0.00%> (-0.99%) ⬇️
crates/transaction-pool/src/pool/pending.rs 75.87% <0.00%> (-9.44%) ⬇️
... and 15 more

... and 96 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.54% <2.50%> (-0.21%) ⬇️
unit-tests 64.40% <51.25%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.44% <25.00%> (+0.11%) ⬆️
blockchain tree 83.01% <ø> (-0.02%) ⬇️
pipeline 89.66% <78.57%> (+2.52%) ⬆️
storage (db) 74.19% <ø> (-0.10%) ⬇️
trie 94.70% <ø> (+0.05%) ⬆️
txpool 46.00% <8.13%> (-1.84%) ⬇️
networking 77.63% <100.00%> (-0.09%) ⬇️
rpc 58.28% <ø> (-0.07%) ⬇️
consensus 64.46% <ø> (-0.50%) ⬇️
revm 33.68% <ø> (-0.08%) ⬇️
payload builder 6.61% <ø> (ø)
primitives 88.01% <65.28%> (-0.32%) ⬇️

@mattsse mattsse requested a review from Rjected July 16, 2023 10:43
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @Rjected

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Jul 16, 2023
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise looks good

etc/grafana/dashboards/overview.json Outdated Show resolved Hide resolved
@onbjerg onbjerg changed the title Adding outgoing metric to grafana dashboard feat: add dial metric to dashboard Jul 19, 2023
@onbjerg onbjerg added the C-enhancement New feature or request label Jul 19, 2023
@Rjected
Copy link
Member

Rjected commented Jul 24, 2023

ping @i-m-aditya :)

@i-m-aditya
Copy link
Contributor Author

@Rjected Apologies. I was occupied with office work last week. Will resolve comments today.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

pending @Rjected

@onbjerg onbjerg enabled auto-merge July 25, 2023 16:36
@onbjerg onbjerg requested a review from Rjected July 25, 2023 16:36
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@onbjerg onbjerg added this pull request to the merge queue Jul 25, 2023
Merged via the queue into paradigmxyz:main with commit 19aa118 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new outgoing dials metric to grafana dashboard
4 participants