feat: add eip 4844 blob tx type #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jul 16, 2023
Rjected
requested changes
Jul 16, 2023
| mem::size_of::<u128>() + // value | ||
| self.access_list.size() + // access_list | ||
| self.input.len() + // input | ||
| self.blob_hashes.len() * mem::size_of::<H256>() + // blob hashes size |
There was a problem hiding this comment.
Should be capacity since it's a Vec
Suggested change
| self.blob_hashes.len() * mem::size_of::<H256>() + // blob hashes size | |
| self.blob_hashes.capacity() * mem::size_of::<H256>() + // blob hashes size |
Codecov Report
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gakonst
reviewed
Jul 20, 2023
Comment on lines
+283
to
+284
| #[inline] | ||
| pub fn size(&self) -> usize { |
There was a problem hiding this comment.
@Rjected should we make this a trait?
There was a problem hiding this comment.
yes, we should make this a trait, will open an issue
mattsse
approved these changes
Jul 24, 2023
merklefruit
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Jul 27, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3746