Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): format MDBX flags doc comments #3905

Merged
merged 1 commit into from
Jul 25, 2023
Merged

chore(storage): format MDBX flags doc comments #3905

merged 1 commit into from
Jul 25, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jul 25, 2023 •
edited
Loading

As per PR title

@shekhirin shekhirin requested a review from mattsse July 25, 2023 12:37
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #3905 (238c01a) into main (1b31a55) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/storage/libmdbx-rs/src/flags.rs 53.16% <ø> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.52% <ø> (-0.01%) ⬇️
unit-tests 64.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.24% <ø> (ø)
blockchain tree 83.01% <ø> (ø)
pipeline 89.66% <ø> (ø)
storage (db) 74.19% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (ø)
networking 77.62% <ø> (-0.04%) ⬇️
rpc 58.27% <ø> (-0.01%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 88.06% <ø> (+0.02%) ⬆️

@shekhirin shekhirin added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit ab9a2e6 Jul 25, 2023
@shekhirin shekhirin deleted the alexey/mdbx-flags-doc branch July 25, 2023 13:30
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
@shekhirin @merklefruit
chore(storage): format MDBX flags doc comments (paradigmxyz#3905)
f09dada
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse