Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Hardfork::Cancun #3933

Merged
merged 4 commits into from
Jul 26, 2023
Merged

feat: add Hardfork::Cancun #3933

merged 4 commits into from
Jul 26, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 26, 2023

ref #2893

add cancun variant to unblock new consensus checks

@mattsse mattsse requested a review from gakonst as a code owner July 26, 2023 16:07
@mattsse mattsse added the M-eip This change relates to the implementation of an EIP label Jul 26, 2023
@mattsse mattsse requested a review from Rjected July 26, 2023 16:09
Rjected
Rjected approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/primitives/src/hardfork.rs Outdated Show resolved Hide resolved
@Rjected
Copy link
Member

Rjected commented Jul 26, 2023

looks like bin/reth/src/init.rs needs some changes for CI to run

mattsse and others added 2 commits July 26, 2023 18:21
@mattsse @Rjected
Update crates/primitives/src/hardfork.rs
e546ec5 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@mattsse
fix missing arg
b30db4d
@mattsse mattsse requested a review from onbjerg as a code owner July 26, 2023 16:25
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Merging #3933 (ae292e5) into main (8cdb097) will decrease coverage by 0.09%.
The diff coverage is 27.27%.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/chain/spec.rs 96.39% <11.11%> (-1.31%) ⬇️
bin/reth/src/init.rs 97.19% <100.00%> (ø)
crates/primitives/src/hardfork.rs 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.56% <9.09%> (+0.01%) ⬆️
unit-tests 64.44% <27.27%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.24% <100.00%> (ø)
blockchain tree 83.01% <ø> (ø)
pipeline 89.68% <ø> (ø)
storage (db) 74.19% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (-0.57%) ⬇️
networking 77.68% <ø> (-0.21%) ⬇️
rpc 58.57% <ø> (-0.01%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.94% <23.80%> (-0.15%) ⬇️

@onbjerg onbjerg added the C-enhancement New feature or request label Jul 26, 2023
@onbjerg onbjerg enabled auto-merge July 26, 2023 16:35
@onbjerg onbjerg added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit aa5d39d Jul 26, 2023
@onbjerg onbjerg deleted the matt/add-cancun-hardfork branch July 26, 2023 16:53
@rkrasiuk rkrasiuk added the E-cancun Related to the Cancun network upgrade label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
C-enhancement New feature or request E-cancun Related to the Cancun network upgrade M-eip This change relates to the implementation of an EIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattsse @Rjected @onbjerg @rkrasiuk