feat(engine): require VALID latest FCU status before pruning
#3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/pruner-engine-conditions
branch
from
c93777f
to
1265547
Compare
Codecov Report
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shekhirin
changed the title
VALID latest FCU status before pruning
mattsse
requested changes
Aug 2, 2023
Comment on lines
1720
to
1723
| this.forkchoice_state_tracker | ||
| .latest_status() | ||
| .map(|status| status.is_valid()) | ||
| .unwrap_or_default() |
There was a problem hiding this comment.
this makes
there is .is_latest_valid() already, we can now remove the unused attr there
mattsse
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this check, we will try to start the pruner on first start even before the node is synced.