Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: deny warnings only in lint jobs #3982

Merged
merged 1 commit into from
Jul 29, 2023
Merged

ci: deny warnings only in lint jobs #3982

merged 1 commit into from
Jul 29, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jul 28, 2023 •
edited
Loading

Fixes #3976

I've kept RUSTFLAGS: -D warnings only in ci.yml, deny.yml and sanity.yml

@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #3982 (dbae9fb) into main (d8677b4) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

see 5 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.34% <ø> (-0.01%) ⬇️
unit-tests 64.26% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.21% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.14% <ø> (+0.60%) ⬆️
networking 77.64% <ø> (-0.02%) ⬇️
rpc 58.50% <ø> (-0.01%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.08% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.82% <ø> (+<0.01%) ⬆️

@mattsse mattsse added the A-meta Changes in the contributor workflow and planning label Jul 29, 2023
mattsse
mattsse approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with that since we have a few warnings due to unfixed clippy lints in deps for example

any introduced warnings/clippy will be caught by the clippy run anyway

@mattsse mattsse added this pull request to the merge queue Jul 29, 2023
Merged via the queue into paradigmxyz:main with commit 555a1dd Jul 29, 2023
@DaniPopes DaniPopes deleted the ci-warnings branch July 29, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: run tests regardless of warnings
2 participants
@DaniPopes @mattsse