feat(pruner): account history #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshieDo
reviewed
Jul 31, 2023
shekhirin
requested review from
mattsse,
Rjected,
rakita,
onbjerg,
rkrasiuk and
gakonst
as code owners
shekhirin
force-pushed
the
alexey/pruner-account-history
branch
2 times, most recently
from
b9a7784 to
13131a4
Compare
shekhirin
added
C-enhancement
joshieDo
approved these changes
Aug 1, 2023
| )?; | ||
|
|
||
| let mut cursor = provider.tx_ref().cursor_write::<tables::AccountHistory>()?; | ||
| while let Some(result) = cursor.next()? { |
There was a problem hiding this comment.
can we just add a short summary comment on what we're doing on this loop?
a lot of if-else conditions.... having a short summary before diving in is helpful imo
edit: something like the PR summary actually
shekhirin
force-pushed
the
alexey/pruner-account-history
branch
from
670667f to
f7c0d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3692
Prunes:
AccountChangeSettable: all block number keys (and their subkeys which are account addresses) which need to be prunedAccountHistorytable:highest_block_numberless than or equal to the target block number for pruning, delete the shard completely.highest_block_numbergreater than the target block number for pruning, filter block numbers inside the shard which are less than the target block number for pruning.