Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add example how to install additional rpc namespace #4005

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 31, 2023

Closes #4001

Add an example that shows how to extend the reth default CLI with custom rpc namespace

this also adds a few reexport mods for convenience

@mattsse mattsse added the A-cli Related to the reth CLI label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #4005 (dde3fc5) into main (dee14c7) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/cli/mod.rs 34.40% <0.00%> (ø)
bin/reth/src/node/mod.rs 12.06% <ø> (-0.12%) ⬇️
crates/rpc/rpc-builder/src/lib.rs 63.59% <0.00%> (-0.57%) ⬇️

... and 15 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.23% <0.00%> (-0.03%) ⬇️
unit-tests 64.14% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.63% <0.00%> (-0.07%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 90.03% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.40% <ø> (-0.61%) ⬇️
networking 77.51% <ø> (ø)
rpc 58.32% <0.00%> (-0.04%) ⬇️
consensus 63.51% <ø> (ø)
revm 33.10% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 88.06% <ø> (+0.01%) ⬆️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the example is simple + docs are informative

@Rjected Rjected added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit b28bc8d Aug 1, 2023
@Rjected Rjected deleted the matt/add-rpc-ext-example branch August 1, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example how to extend default cli with additional rpc impls
2 participants