Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): ots_getBlockDetails and ots_getBlockDetailsByHash #4007

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ZePedroResende
Copy link
Contributor

This tackles #3726 by adding the implementations of ots_getBlockDetails and ots_getBlockDetailsByHash

  • Add ots_getBlockDetails and ots_getBlockDetailsByHash implementation
  • Implement From trait for BlockDetails from Rich<Block>
  • Implement From trait for OtsBlock from Block
  • Add Default trait for InternalIssuance as a placeholder

This tackles paradigmxyz#3726 by adding the implementations of `ots_getBlockDetails` and `ots_getBlockDetailsByHash`

* Add `ots_getBlockDetails` and `ots_getBlockDetailsByHash`
  implementation
* Implement From trait for `BlockDetails` from `Rich<Block>`
* Implement From trait for `OtsBlock` from `Block`
* Add Default trait for `InternalIssuance` as a placeholder
@ZePedroResende ZePedroResende marked this pull request as draft July 31, 2023 17:11
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #4007 (f5ad359) into main (f41386d) will decrease coverage by 0.25%.
Report is 15 commits behind head on main.
The diff coverage is 21.05%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-types/src/eth/block.rs 39.08% <ø> (+0.23%) ⬆️
crates/rpc/rpc-types/src/otterscan.rs 0.00% <0.00%> (ø)
crates/rpc/rpc/src/otterscan.rs 98.43% <100.00%> (+0.05%) ⬆️

... and 49 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.23% <21.05%> (-0.11%) ⬇️
unit-tests 64.12% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.63% <ø> (-1.05%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 90.03% <ø> (+0.21%) ⬆️
storage (db) 74.30% <ø> (-0.01%) ⬇️
trie 94.70% <ø> (ø)
txpool 45.40% <ø> (-0.61%) ⬇️
networking 77.48% <ø> (-0.18%) ⬇️
rpc 58.28% <21.05%> (-0.19%) ⬇️
consensus 63.51% <ø> (ø)
revm 33.10% <ø> (+0.01%) ⬆️
payload builder 6.58% <ø> (ø)
primitives 88.06% <ø> (+0.15%) ⬆️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse marked this pull request as ready for review August 1, 2023 10:41
@mattsse mattsse added the A-rpc Related to the RPC implementation label Aug 1, 2023
@mattsse mattsse added this pull request to the merge queue Aug 1, 2023
Merged via the queue into paradigmxyz:main with commit 3a44196 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants