Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix PrefixSetMut doc comment #4015

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jul 31, 2023

Previously the comment said that PrefixSetMut used a BTreeSet, which is no longer true, so the comment is updated with how it works currently.

@Rjected Rjected added C-docs An addition or correction to our documentation C-enhancement New feature or request A-trie Related to Merkle Patricia Trie implementation labels Jul 31, 2023
@Rjected Rjected requested a review from rkrasiuk as a code owner July 31, 2023 22:10
@Rjected Rjected changed the title chore: fix PrefixSetMut doc comment` chore: fix PrefixSetMut doc comment Jul 31, 2023
@Rjected Rjected force-pushed the dan/fix-prefix-set-docs branch from b292027 to 65f35ef Compare July 31, 2023 22:12
@Rjected Rjected force-pushed the dan/fix-prefix-set-docs branch from 65f35ef to 8ada862 Compare July 31, 2023 22:13
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #4015 (8ada862) into main (27c65d2) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/trie/src/prefix_set/mod.rs 83.11% <ø> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.24% <ø> (+<0.01%) ⬆️
unit-tests 64.16% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.63% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.03% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (+0.60%) ⬆️
networking 77.47% <ø> (-0.18%) ⬇️
rpc 58.35% <ø> (-0.03%) ⬇️
consensus 63.51% <ø> (ø)
revm 33.10% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 88.06% <ø> (-0.03%) ⬇️

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2023
@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit a1c3a44 Aug 1, 2023
@rkrasiuk rkrasiuk deleted the dan/fix-prefix-set-docs branch August 1, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-docs An addition or correction to our documentation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants