Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move call op match to fn #4047

Merged
merged 1 commit into from
Aug 3, 2023
Merged

chore: move call op match to fn #4047

merged 1 commit into from
Aug 3, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 3, 2023

move match over calllike opcodes to standalone function

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4047 (70b76d8) into main (8d0aa64) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
...revm/revm-inspectors/src/tracing/builder/parity.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.44% <0.00%> (-0.01%) ⬇️
unit-tests 64.12% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.85% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 47.96% <ø> (+0.59%) ⬆️
networking 77.42% <ø> (-0.06%) ⬇️
rpc 57.84% <ø> (+<0.01%) ⬆️
consensus 63.86% <ø> (ø)
revm 32.68% <0.00%> (-0.04%) ⬇️
payload builder 6.58% <ø> (ø)
primitives 87.99% <ø> (-0.03%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, makes sense

@mattsse mattsse added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 0d33585 Aug 3, 2023
@mattsse mattsse deleted the matt/move-calllike-to-fn branch August 3, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants