Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make unit type default #4141

Merged
merged 1 commit into from
Aug 10, 2023
Merged

chore: make unit type default #4141

merged 1 commit into from
Aug 10, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 10, 2023

make unit type default

@mattsse mattsse added the A-rpc Related to the RPC implementation label Aug 10, 2023
@mattsse mattsse requested a review from rkrasiuk August 10, 2023 12:06
rkrasiuk
rkrasiuk approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks cleaner!

@mattsse mattsse enabled auto-merge August 10, 2023 12:12
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #4141 (788714b) into main (072c840) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/cli/ext.rs 1.78% <0.00%> (ø)
crates/rpc/rpc-builder/src/lib.rs 63.48% <50.00%> (-0.11%) ⬇️

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.87% <33.33%> (-0.01%) ⬇️
unit-tests 64.06% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <0.00%> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.67% <ø> (-0.05%) ⬇️
txpool 47.66% <ø> (ø)
networking 77.70% <ø> (-0.08%) ⬇️
rpc 58.66% <50.00%> (-0.02%) ⬇️
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.91% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 628495a Aug 10, 2023
@mattsse mattsse deleted the matt/make-context-unit-type branch August 10, 2023 12:25
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@mattsse @alessandromazza98
chore: make unit type default (paradigmxyz#4141)
ed407ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk