Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict max active queries #4178

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: restrict max active queries #4178

merged 1 commit into from
Aug 14, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 13, 2023

ref #4155

this enforces that only x queries are active at a time

we should increase the rate separately

@mattsse mattsse requested a review from Rjected as a code owner August 13, 2023 09:43
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-networking Related to networking in general labels Aug 13, 2023
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #4178 (9f36178) into main (d152c9e) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/common/src/ratelimit.rs 87.64% <100.00%> (+0.43%) ⬆️
crates/net/dns/src/query.rs 95.27% <100.00%> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.92% <100.00%> (+<0.01%) ⬆️
unit-tests 64.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.81% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 51.43% <ø> (ø)
networking 77.75% <100.00%> (-0.03%) ⬇️
rpc 58.69% <ø> (+0.02%) ⬆️
consensus 63.73% <ø> (ø)
revm 32.18% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.83% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 7223649 Aug 14, 2023
24 checks passed
@mattsse mattsse deleted the matt/enforce-max-queries branch August 14, 2023 10:01
@bemevolent bemevolent mentioned this pull request Aug 14, 2023
1 task
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants