perf: use futures unordered for active requests #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 22 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
added
the
C-perf
Rjected
approved these changes
Aug 16, 2023
| @@ -575,27 +575,23 @@ where | |||
|
|
|||
| // Advance all requests. | |||
| // We remove each request one by one and add them back. | |||
There was a problem hiding this comment.
nit: comment is not accurate now
alessandromazza98
pushed a commit
to alessandromazza98/reth
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace vec of futures with futures unordered
🤖 Generated by Copilot at 7126599
Improved network transaction requests and added documentation in
rethcrate. The changes useFuturesUnorderedand a customFutureto handle multiple requests concurrently and handle errors gracefully. The new code is documented with comments and docstrings incrates/net/network/src/transactions.rs.