Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): add missing DebugApi methods #4321

Merged
merged 1 commit into from
Aug 24, 2023
Merged

feat(rpc): add missing DebugApi methods #4321

merged 1 commit into from
Aug 24, 2023

Conversation

tcoratger
Copy link
Contributor

Should solve #1701.

@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #4321 (0922687) into main (1859321) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-api/src/debug.rs 100.00% <ø> (ø)
crates/rpc/rpc/src/debug.rs 6.88% <0.00%> (-2.10%) ⬇️

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.77% <0.00%> (-0.04%) ⬇️
unit-tests 63.54% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.11% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (ø)
txpool 47.29% <ø> (-0.53%) ⬇️
networking 77.46% <ø> (-0.04%) ⬇️
rpc 57.95% <0.00%> (-0.85%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 86.08% <ø> (-0.01%) ⬇️

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Aug 23, 2023
mattsse
mattsse approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@mattsse mattsse added this pull request to the merge queue Aug 24, 2023
Merged via the queue into paradigmxyz:main with commit c2436a9 Aug 24, 2023
23 checks passed
@tcoratger tcoratger deleted the rpc-debug branch September 21, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @mattsse @rkrasiuk