Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(book): [prune] config section #4328

Merged
merged 1 commit into from
Aug 23, 2023
Merged

feat(book): [prune] config section #4328

merged 1 commit into from
Aug 23, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Aug 23, 2023

Partially #3480, need to also add the --full CLI argument and a separate section about pruning best practices.

@shekhirin shekhirin added C-docs An addition or correction to our documentation A-pruning Related to pruning or full node C-enhancement New feature or request labels Aug 23, 2023
@shekhirin shekhirin marked this pull request as ready for review August 23, 2023 14:17
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4328 (5f4ab43) into main (5a7a57d) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/args/pruning_args.rs 20.00% <ø> (ø)
crates/primitives/src/lib.rs 100.00% <ø> (ø)
crates/primitives/src/prune/mod.rs 36.84% <ø> (ø)
crates/primitives/src/prune/target.rs 59.09% <0.00%> (ø)
crates/prune/src/pruner.rs 78.63% <100.00%> (ø)
crates/storage/provider/src/post_state/mod.rs 95.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.80% <0.00%> (-0.02%) ⬇️
unit-tests 63.68% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.11% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <100.00%> (ø)
trie 94.88% <ø> (ø)
txpool 47.29% <ø> (ø)
networking 77.47% <ø> (-0.02%) ⬇️
rpc 58.79% <ø> (-0.02%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.09% <0.00%> (ø)

@shekhirin shekhirin added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 9a97640 Aug 23, 2023
24 checks passed
@shekhirin shekhirin deleted the alexey/pruning-book branch August 23, 2023 16:05
@shekhirin shekhirin removed the C-enhancement New feature or request label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pruning Related to pruning or full node C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants