Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana): sort stages #4373

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat(grafana): sort stages #4373

merged 3 commits into from
Aug 28, 2023

Conversation

jeremie-H
Copy link
Contributor

In the grafana dashboard, I think it could be easier to follow the progress if stages are in the right order

Before

image

After

image

"MerkleUnwind": 5,
"SenderRecovery": 3,
"StorageHashing": 7,
"Time": 13,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is Time needed here?

Copy link
Contributor Author

@jeremie-H jeremie-H Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it's automatically added, I've removed this field

@rkrasiuk rkrasiuk added the A-observability Related to tracing, metrics, logs and other observability tools label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4373 (2d7a413) into main (72b211e) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.68% <ø> (-0.02%) ⬇️
unit-tests 63.67% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.01% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.72% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.72% <ø> (ø)
networking 77.49% <ø> (-0.02%) ⬇️
rpc 57.96% <ø> (ø)
consensus 63.53% <ø> (ø)
revm 31.89% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.28% <ø> (-0.03%) ⬇️

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@onbjerg onbjerg enabled auto-merge August 28, 2023 13:42
@onbjerg onbjerg added this pull request to the merge queue Aug 28, 2023
Merged via the queue into paradigmxyz:main with commit 47683fd Aug 28, 2023
23 checks passed
@jeremie-H
Copy link
Contributor Author

Hello,
@onbjerg, I suggest to reopen and reapply this MR, my work was delete by @shekhirin on this MR : #4385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants