Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primitives): increase transaction senders pruning batch size #4383

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Aug 28, 2023

This PR increases the Transaction Senders prune part batch size not sacrificing the requirement for freelist still decreasing. You can see on the chart that TxSenders table entries (green line, left Y axis) is decreasing faster after the batch size increase, while freelist size (yellow line, right Y axis) started decreasing slower but still below zero:

image

@shekhirin shekhirin marked this pull request as ready for review August 28, 2023 15:38
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4383 (9f0ce6e) into main (47683fd) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/prune/batch_sizes.rs 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.70% <50.00%> (-0.01%) ⬇️
unit-tests 63.65% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.01% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.72% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.23% <ø> (ø)
networking 77.50% <ø> (-0.03%) ⬇️
rpc 57.96% <ø> (-0.01%) ⬇️
consensus 63.53% <ø> (ø)
revm 31.89% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.30% <100.00%> (ø)

@shekhirin shekhirin added C-enhancement New feature or request A-pruning Related to pruning or full node labels Aug 28, 2023
@shekhirin shekhirin added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit f303b5c Aug 28, 2023
24 checks passed
@shekhirin shekhirin deleted the alexey/pruning-tx-senders-batch-size branch August 28, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pruning Related to pruning or full node C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants