Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin Grafana version in docker-compose.yml #4395

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

shekhirin
Copy link
Collaborator

When dashboard is exported, it has a Grafana version specified:

{
"type": "grafana",
"id": "grafana",
"name": "Grafana",
"version": "10.1.0"
},

To both prevent breaking changes and unwanted version bumps in dashboard JSON, pin the Grafana version in docker-compose.yml file.

@shekhirin shekhirin added the A-observability Related to tracing, metrics, logs and other observability tools label Aug 29, 2023
@shekhirin shekhirin requested a review from Rjected August 29, 2023 17:13
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #4395 (37ccd05) into main (80ee49b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

see 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.72% <ø> (+<0.01%) ⬆️
unit-tests 63.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.01% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.72% <ø> (ø)
trie 94.88% <ø> (+0.03%) ⬆️
txpool 47.37% <ø> (ø)
networking 77.52% <ø> (+0.03%) ⬆️
rpc 57.96% <ø> (-0.02%) ⬇️
consensus 63.53% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.17% <ø> (ø)

@shekhirin shekhirin added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 4057953 Aug 29, 2023
24 checks passed
@shekhirin shekhirin deleted the alexey/docker-compose-grafana-version branch August 29, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants