Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename price bump arg #4399

Merged
merged 1 commit into from
Aug 29, 2023
Merged

chore: rename price bump arg #4399

merged 1 commit into from
Aug 29, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 29, 2023

@mattsse mattsse requested a review from onbjerg as a code owner August 29, 2023 17:45
@mattsse mattsse requested a review from Rjected August 29, 2023 17:45
@mattsse mattsse added A-cli Related to the reth CLI M-changelog This change should be included in the changelog labels Aug 29, 2023
@mattsse mattsse enabled auto-merge August 29, 2023 17:51
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #4399 (874b415) into main (80ee49b) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/args/txpool_args.rs 25.71% <100.00%> (ø)

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.72% <0.00%> (-0.01%) ⬇️
unit-tests 63.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.01% <100.00%> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.72% <ø> (ø)
trie 94.84% <ø> (ø)
txpool 47.86% <ø> (+0.49%) ⬆️
networking 77.51% <ø> (+0.02%) ⬆️
rpc 57.95% <ø> (-0.03%) ⬇️
consensus 63.53% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.15% <ø> (-0.02%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 4a2c169 Aug 29, 2023
@mattsse mattsse deleted the matt/rename-pricebump-arg branch August 29, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants