Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pruning): dont check pruning on every storage change for the same block #4402

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

joshieDo
Copy link
Collaborator

As the title suggests.

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-pruning Related to pruning or full node labels Aug 29, 2023
@joshieDo joshieDo requested a review from shekhirin August 29, 2023 18:37
@joshieDo joshieDo requested a review from rakita as a code owner August 29, 2023 18:37
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now this is what i call performance oriented programming

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #4402 (8b28e0f) into main (0c7a937) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/storage/provider/src/post_state/mod.rs 95.00% <100.00%> (-0.01%) ⬇️

... and 17 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.72% <0.00%> (-0.02%) ⬇️
unit-tests 63.64% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.01% <ø> (-0.01%) ⬇️
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.72% <100.00%> (-0.01%) ⬇️
trie 94.88% <ø> (ø)
txpool 48.25% <ø> (+0.77%) ⬆️
networking 77.48% <ø> (-0.05%) ⬇️
rpc 57.94% <ø> (-0.02%) ⬇️
consensus 63.54% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.77% <ø> (ø)
primitives 86.21% <ø> (+<0.01%) ⬆️

@onbjerg onbjerg added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit d0a5a19 Aug 31, 2023
@onbjerg onbjerg deleted the joshie/fix-prune-check-storage branch August 31, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pruning Related to pruning or full node C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants