Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass parent beacon block root to payload builder #4425

Merged
merged 2 commits into from
Sep 4, 2023
Merged

feat: pass parent beacon block root to payload builder #4425

merged 2 commits into from
Sep 4, 2023

Conversation

alessandromazza98
Copy link
Contributor

Closes #4401

This PR should close that issue. I'm actually not 100% sure that it is complete. Please let me know.

@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #4425 (86bc6c9) into main (cd71f68) will decrease coverage by 0.06%.
Report is 15 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/payload/basic/src/lib.rs 0.00% <0.00%> (ø)
crates/payload/builder/src/payload.rs 0.00% <0.00%> (ø)

... and 34 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.66% <0.00%> (-0.06%) ⬇️
unit-tests 63.73% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.61% <ø> (-0.03%) ⬇️
blockchain tree 83.52% <ø> (ø)
pipeline 90.47% <ø> (+0.21%) ⬆️
storage (db) 74.81% <ø> (-0.01%) ⬇️
trie 94.88% <ø> (ø)
txpool 47.59% <ø> (-1.04%) ⬇️
networking 77.45% <ø> (-0.05%) ⬇️
rpc 57.40% <ø> (-0.17%) ⬇️
consensus 63.42% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.34% <0.00%> (-0.03%) ⬇️
primitives 86.12% <ø> (-0.06%) ⬇️

@onbjerg onbjerg changed the title pass parent beacon block root to payload builder feat: pass parent beacon block root to payload builder Aug 31, 2023
@onbjerg onbjerg added C-enhancement New feature or request A-block-building Related to block building labels Aug 31, 2023
@Rjected Rjected added M-eip This change relates to the implementation of an EIP E-cancun Related to the Cancun network upgrade labels Aug 31, 2023
Rjected
Rjected requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important note on making sure we keep the root as None pre-cancun, otherwise this looks good

mattsse
mattsse approved these changes Sep 3, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @Rjected

Rjected
Rjected approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mattsse mattsse added this pull request to the merge queue Sep 4, 2023
Merged via the queue into paradigmxyz:main with commit d9334ee Sep 4, 2023
@alessandromazza98 alessandromazza98 deleted the issue4401 branch September 11, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-block-building Related to block building C-enhancement New feature or request E-cancun Related to the Cancun network upgrade M-eip This change relates to the implementation of an EIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass parent beacon block root to payload builder
4 participants
@alessandromazza98 @Rjected @mattsse @onbjerg