Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant clones #4485

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Remove redundant clones #4485

merged 2 commits into from
Sep 5, 2023

Conversation

JosepBove
Copy link
Contributor

@JosepBove JosepBove commented Sep 5, 2023 •
edited
Loading

Just removing redundant cones

@JosepBove JosepBove changed the title Merge branch 'main' of https://github.com/paradigmxyz/reth Remove redundant clones Sep 5, 2023
@JosepBove JosepBove changed the title Remove redundant clones Draft: Remove redundant clones Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #4485 (5cc6601) into main (1ec4d46) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/recover/storage_tries.rs 4.76% <0.00%> (ø)
crates/consensus/beacon/src/engine/mod.rs 74.60% <0.00%> (+0.19%) ⬆️
crates/prune/src/pruner.rs 82.83% <ø> (ø)
...torage/provider/src/providers/database/provider.rs 80.08% <100.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.62% <0.00%> (-0.01%) ⬇️
unit-tests 63.83% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.71% <0.00%> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 74.98% <100.00%> (ø)
trie 94.84% <ø> (-0.04%) ⬇️
txpool 47.90% <ø> (-0.03%) ⬇️
networking 77.46% <ø> (+<0.01%) ⬆️
rpc 57.40% <ø> (+<0.01%) ⬆️
consensus 63.40% <0.00%> (+0.08%) ⬆️
revm 31.74% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.15% <ø> (ø)

@JosepBove JosepBove changed the title Draft: Remove redundant clones Remove redundant clones Sep 5, 2023
@JosepBove
Copy link
Contributor Author

Removed draft, could be merged now

@rkrasiuk rkrasiuk added the C-debt Refactor of code section that is hard to understand or maintain label Sep 5, 2023
@rkrasiuk rkrasiuk added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2023
@rkrasiuk rkrasiuk added this pull request to the merge queue Sep 5, 2023
Merged via the queue into paradigmxyz:main with commit b2750e0 Sep 5, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosepBove @rkrasiuk