Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2511: extended reth-rpc example with custom rpc ext #4508

Merged
merged 7 commits into from
Sep 8, 2023
Merged

#2511: extended reth-rpc example with custom rpc ext #4508

merged 7 commits into from
Sep 8, 2023

Conversation

loocapro
Copy link
Contributor

@loocapro loocapro commented Sep 7, 2023

ref #2511

  • Refactored the structure of the example as a single cargo project
  • Used with_noop_pool and with_noop_network methods from RpcModuleBuilder instead of their Defaults
  • Added MyRpcExt to showcase how to add custom methods on this example

@loocapro loocapro changed the title #2511 #2511: extended reth-rpc example with custom rpc ext Sep 7, 2023
mattsse
mattsse requested changes Sep 7, 2023
View reviewed changes
examples/rpc-db/Cargo.toml Outdated Show resolved Hide resolved
loocapro
loocapro commented Sep 7, 2023
View reviewed changes
bin/reth/src/utils.rs Outdated Show resolved Hide resolved
mattsse
mattsse requested changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last naming nit

bin/reth/src/utils.rs Outdated Show resolved Hide resolved
bin/reth/src/lib.rs Show resolved Hide resolved
bin/reth/src/lib.rs Show resolved Hide resolved
@loocapro
Copy link
Contributor Author

loocapro commented Sep 8, 2023

last naming nit

Done thanks!

@mattsse mattsse added the C-enhancement New feature or request label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Merging #4508 (e81b08e) into main (f490f55) will increase coverage by 0.01%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/utils.rs 2.25% <ø> (ø)

... and 17 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <ø> (+0.01%) ⬆️
unit-tests 63.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.71% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.33% <ø> (+0.26%) ⬆️
trie 94.88% <ø> (ø)
txpool 47.47% <ø> (ø)
networking 77.45% <ø> (-0.02%) ⬇️
rpc 57.44% <ø> (-0.05%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.42% <ø> (-0.07%) ⬇️

📢 Have feedback on the report? Share it here.

@mattsse mattsse added this pull request to the merge queue Sep 8, 2023
Merged via the queue into paradigmxyz:main with commit 5f329e7 Sep 8, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loocapro @mattsse