fix: wake future after buffering pong #4536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was uncovered in hive tests, where hive sends a single
Ping
after the eth handshake, and waits for aPong
response before sending any other requests over p2p. When this happens, we don't have any messages to send, so we neverpoll_flush
thePong
out of the stream.To fix this, we call the waker, so the
Sink
can be polled at least once after theStream
returnsPoll::Pending
.