Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable geth tests again #4544

Merged
merged 1 commit into from
Sep 11, 2023
Merged

test: enable geth tests again #4544

merged 1 commit into from
Sep 11, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 10, 2023

🤖 Generated by Copilot at 931abfe

This pull request enhances the integration tests for the net crate by using a feature flag for Geth, reactivating some skipped tests, and simplifying the port setup in connect.rs.

@mattsse mattsse added the C-test A change that impacts how or what we test label Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #4544 (931abfe) into main (fc9f116) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

see 17 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <ø> (+0.05%) ⬆️
unit-tests 63.95% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.83% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.50% <ø> (ø)
networking 77.52% <ø> (+0.08%) ⬆️
rpc 57.35% <ø> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.67% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.50% <ø> (-0.01%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit cc576bc Sep 11, 2023
25 checks passed
@mattsse mattsse deleted the matt/re-enable-geth-tests branch September 11, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants