Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin git dependencies to specific revs #4552

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

DaniPopes
Copy link
Member

Closes #4537

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #4552 (a5fc1db) into main (692a081) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

see 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <ø> (-0.01%) ⬇️
unit-tests 63.96% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.83% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.84% <ø> (-0.04%) ⬇️
txpool 47.50% <ø> (-0.51%) ⬇️
networking 77.53% <ø> (-0.01%) ⬇️
rpc 57.39% <ø> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.67% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.53% <ø> (-0.01%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable, even if this requires manual updates now, but if it helps to prevent issues for dependant crates sgtm

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Sep 11, 2023
@DaniPopes
Copy link
Member Author

I also pinned revm instead of using crates.io patch in ff51ac0.
This also fixes the need for users to patch as well, as long as we don't depend on other crates that depend on revm crates.io themselves.

@mattsse
Copy link
Collaborator

mattsse commented Sep 11, 2023

good call, getting tired of answering that question why it does not compile

@mattsse
Copy link
Collaborator

mattsse commented Sep 11, 2023

@DaniPopes let's switch to boa 0.17 from crates?

@mattsse mattsse added this pull request to the merge queue Sep 11, 2023
Merged via the queue into paradigmxyz:main with commit 7dd14a7 Sep 11, 2023
24 checks passed
@DaniPopes DaniPopes deleted the pin-gits branch September 11, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock git dependency to a revision in Cargo.toml
2 participants